Micro-services deployment #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrybowski
force-pushed
the
micro-services
branch
2 times, most recently
from
f7001a6 to
1e1df6f
Compare
nrybowski
force-pushed
the
micro-services
branch
from
0311f67 to
daa6e85
Compare
|
Rebase on 85f764d. |
nrybowski
force-pushed
the
micro-services
branch
2 times, most recently
from
bf388a1 to
1f94ec1
Compare
anthonygego
reviewed
Feb 1, 2023
There was a problem hiding this comment.
This is pretty cool.
I'm however wondering if this is not premature optimization to split the package files at this time.
It would probably be more secure for coherency, in a first time, to install the whole package in the inginious-base container and make the other containers just run the appropriate things. That'll probably not used more space (even though it's only a few megabytes). Currently, it breaks the version number footer, which is a bit sad.
This package split could be performed in a second time, not only for a container deployment.
We can also discuss if it's worth putting those files in this particular repo as the containerfiles could be relying on pip installs. It would probably be better to maintain and be more self-documenting for sysadmins to provide docker compose files that actually perform the same operations as would be necessary for manual install method.
nrybowski
force-pushed
the
micro-services
branch
from
eb6ab61 to
ac33aef
Compare
|
Rebase on 61ead04. |
anthonygego
reviewed
Sep 21, 2023
anthonygego
reviewed
Dec 6, 2023
nrybowski
force-pushed
the
micro-services
branch
from
cbb0316 to
b34e3e3
Compare
Suggested changes by @anthonygego Co-authored-by: Anthony Gégo <[email protected]>
- Add .env file with defaults values for REGISTRY and VERSION variables - Fix "docker compose" syntax for modern deployements
nrybowski
force-pushed
the
micro-services
branch
from
b34e3e3 to
861d608
Compare
|
Rebase on 80e367a |
|
LGTM. I'll squash all the commits as they are a lot and are essentially additions |
anthonygego
approved these changes
Dec 6, 2023
|
🥳 |
AlexandreDoneux
pushed a commit
to AlexandreDoneux/INGInious
that referenced
this pull request
Dec 7, 2023
* Add backend service * Add agent-docker service * Add agent-mcq service * Add mongo-db container * Layered services images * Add frontend service * [deploy] From Ubuntu to Rocky8 * [deploy] Update README * [deploy] Add initial MongoDB setup * [deploy] Update INGInious stack doc * [deploy] Rebase and update documentation * [deploy] Revert setup sub-division * [deploy] Add core containers build to CI * Use code escape in documentation Suggested changes by @anthonygego Co-authored-by: Anthony Gégo <[email protected]> * [deploy/compose] Build base image in stack deploy * [deploy] Update doc about core containers build * [deploy/base] Document the containerfile * [deploy] Update review comments - Add .env file with defaults values for REGISTRY and VERSION variables - Fix "docker compose" syntax for modern deployements --------- Co-authored-by: Anthony Gégo <[email protected]>
nrybowski
added a commit
that referenced
this pull request
Jan 6, 2025
* Add backend service * Add agent-docker service * Add agent-mcq service * Add mongo-db container * Layered services images * Add frontend service * [deploy] From Ubuntu to Rocky8 * [deploy] Update README * [deploy] Add initial MongoDB setup * [deploy] Update INGInious stack doc * [deploy] Rebase and update documentation * [deploy] Revert setup sub-division * [deploy] Add core containers build to CI * Use code escape in documentation Suggested changes by @anthonygego Co-authored-by: Anthony Gégo <[email protected]> * [deploy/compose] Build base image in stack deploy * [deploy] Update doc about core containers build * [deploy/base] Document the containerfile * [deploy] Update review comments - Add .env file with defaults values for REGISTRY and VERSION variables - Fix "docker compose" syntax for modern deployements --------- Co-authored-by: Anthony Gégo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature #875.
TODO
Define a structure for the Containerfiles and setup files?[ ] Template for setup file rather than hardcoding (since only the dependencies change).[ ] setup.py template. Should be able to retrieve the current INGInious version.[ ] Multi-stage container. Stage 1 produces the setup.py file, Stage 2 is the actual container image.To implement in other PRs